On 08/27/2013 03:05 PM, Tomasz Wroblewski wrote:
diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h
index 403e193..f38c9b7 100644
--- a/xen/include/xen/serial.h
+++ b/xen/include/xen/serial.h
@@ -70,8 +70,9 @@ struct uart_driver {
/* Driver suspend/resume. */
void (*suspend)(struct serial_port *);
void (*resume)(struct serial_port *);
- /* Return number of characters the port can hold for transmit. */
- unsigned int (*tx_ready)(struct serial_port *);
+ /* Return number of characters the port can hold for transmit,
+ * or -EIO if port is inaccesible */
+ int (*tx_ready)(struct serial_port *);
Hi,
This callback is shared between ARM and X86. You forgot to modify ARM UART
driver
(omap, pl011, exynos4210,...), so it breaks Xen unstable compilation on ARM.
pl011.c:209:5: error: initialization from incompatible pointer type [-Werror]
.tx_ready = pl011_tx_ready,
^
pl011.c:209:5: error: (near initialization for ‘pl011_driver.tx_ready’)
[-Werror]
exynos4210-uart.c:298:5: error: initialization from incompatible pointer type
[-Werror]
.tx_ready = exynos4210_uart_tx_ready,
^
exynos4210-uart.c:298:5: error: (near initialization for
‘exynos4210_uart_driver.tx_ready’) [-Werror]
omap-uart.c:285:5: error: initialization from incompatible pointer type
[-Werror]
.tx_ready = omap_uart_tx_ready,
^
Please, send a patch to fix the compilation on ARM.
