Re: [Xen-devel] [PATCH] AMD IOMMU: also allocate IRTEs for HPET MSI

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.13 at 21:06, Suravee Suthikulanit <suravee.suthikulpanit@xxxxxxx> 
>>> wrote:
> Ah,ok.. I found out thatthisonly applies on the family10h system with 
> IOMMUdue to the check in arch/x86/time.c:_disable_pit_irq
> 
> "if (!boot_cpu_has(X86_FEATURE_ARAT))"
> 
> and the condition in arch/x86/cpu/amd.c:_init_amd()
> 
>      /*
>       * Family 0x12 and above processors have APIC timer
>       * running in deep C states.
>       */
>      if (c->x86 > 0x11)
>          set_bit(X86_FEATURE_ARAT, c->x86_capability);
> 
> Jan, doyou think you could also add the comment that this only 
> applicable on family10h?

So are you saying that the check here is wrong (because if the
comment is, the check is too)? If so, I'd prefer a patch coming
from you (AMD) over cooking one myself. And if not, I need
clarification on what you're trying to point out is wrong.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel