[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/apic: remove the legacy bigsmp APIC driver

On 27/08/2013 09:17, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 27.08.13 at 07:44, Matt Wilson <msw@xxxxxxxxxx> wrote:
>> The bigsmp APIC driver was used on legacy (32-bit only) x86 platforms
>> with 8 or more CPUs. In Linux the X86_BIGSMP Kconfig option depends on
>> X86_32. Since we no longer support 32-bit hypervisors on the x86
>> platform we can remove this code.
> The fact that this is 32-bit only in Linux doesn't mean anything.
> Linux has other 64-bit only models, which we don't have (in
> favor of, originally, having a single shared implementation).
> On a system without x2APIC but more than 8 CPUs - how would
> you see us bringing up the CPUs beyond 8? This is particularly
> shown by your adjustment to MP_processor_info_x(), which is
> code removal without replacement.
> Despite Keir's ack, unless I'm overlooking something I'm explicitly
> nack-ing this.

Thanks. You are right of course. Oops!
> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.