Re: [Xen-devel] [PATCH v2-resend 14/30] libxl: ocaml: make Val_defbool GC-proof

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Rob Hoes writes ("[Xen-devel] [PATCH v2-resend 14/30] libxl: ocaml: make 
Val_defbool GC-proof"):
> Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>

I'm afraid I don't understand this at all.  How does this make a
difference ?

(Also, these changes...
> +     bool b;
> -             bool b = libxl_defbool_val(c_val);
> +             b = libxl_defbool_val(c_val);
... definitely don't have any purpose.)

So, the remaining key change is this:

                bool b = libxl_defbool_val(c_val);
> -             v = Val_some(b ? Val_bool(true) : Val_bool(false));
> +             v1 = b ? Val_bool(true) : Val_bool(false);
> +             v2 = Val_some(v1);

Assuming that Val_some is a function, I think this has no semantic
difference.  Can you explain what the difference is ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel