Re: [Xen-devel] [PATCH RFC 1/7] xen/vnuma: subop hypercall and vnuma topology structures.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.13 at 16:06, George Dunlap <George.Dunlap@xxxxxxxxxxxxx> wrote:
> On Tue, Aug 27, 2013 at 9:53 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 27.08.13 at 09:54, Elena Ufimtseva <ufimtseva@xxxxxxxxx> wrote:
>>> Defines XENMEM subop hypercall for PV vNUMA enabled guests and provides
>>> vNUMA topology information from per-domain vnuma topology build info.
>>> TODO:
>>> subop XENMEM hypercall is subject to change to sysctl subop.
>>
>> That would mean it's intended to be used by the tool stack only. I
>> thought that the balloon driver (and perhaps other code) are also
>> intended to be consumers.
> 
> Can Elena take it from your detailed review that you're OK with the
> general approach here?

Not yet - as said in the middle of both review replies, the
enormous amount of formal issues in the patches makes it
very hard to review them, and hence I gave up at those
points. Thus I can only say that it looks okay at a first
glance.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel