Re: [Xen-devel] [PATCH 3/3] VT-d: warn about Compatibility Format Interrupts being enabled by firmware

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, Aug 21, 2013 at 7:38 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> ... as being insecure.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -712,8 +712,8 @@ int enable_intremap(struct iommu *iommu,
>
>      if ( !platform_supports_intremap() )
>      {
> -        dprintk(XENLOG_ERR VTDPREFIX,
> -                "Platform firmware does not support interrupt remapping\n");
> +        printk(XENLOG_ERR VTDPREFIX
> +               " Platform firmware does not support interrupt remapping\n");
>          return -EINVAL;
>      }
>
> @@ -724,15 +724,19 @@ int enable_intremap(struct iommu *iommu,
>      if ( (sts & DMA_GSTS_IRES) && ir_ctrl->iremap_maddr )
>          return 0;
>
> -    sts = dmar_readl(iommu->reg, DMAR_GSTS_REG);

Nit: Might be nice to mention the removal of the redundant read in the
changelog.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel