Re: [Xen-devel] [V10 PATCH 19/23] PVH xen: vmcs related changes

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Mon, Aug 19, 2013 at 5:00 PM, George Dunlap
<George.Dunlap@xxxxxxxxxxxxx> wrote:
> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> 
> wrote:
>> @@ -1294,6 +1534,9 @@ void vmx_do_resume(struct vcpu *v)
>>          hvm_asid_flush_vcpu(v);
>>      }
>>
>> +    if ( is_pvh_vcpu(v) )
>> +        reset_stack_and_jump(vmx_asm_do_vmentry);
>> +
>
> This skips the debugger stuff, but also skips hvm_do_resume().
> hvm_do_resume() has timer and ioreq stuff that's not needed for PVH,
> but it also has code to "Inject a pending hw/sw trap".  Might that
> code not be needed?

hvm_do_resume() also has check_wakeup_from_wait() -- that seems like
it would apply to PVH VMs as well, no?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel