Re: [Xen-devel] [RFC Patch 2/2] tools/xc_domain_getinfo: Implement sane interface for single domain information.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[Xen-devel] [RFC Patch 2/2] tools/xc_domain_getinfo: 
Implement sane interface for single domain information."):
...
> +static void xc_domaininfo_to_dominfo(const xc_domaininfo_t *src,
> +                                     xc_dominfo_t *dst)
> +{
> +    dst->dying    = !!(src->flags & XEN_DOMINF_dying);
> +    dst->shutdown = !!(src->flags & XEN_DOMINF_shutdown);
> +    dst->paused   = !!(src->flags & XEN_DOMINF_paused);
> +    dst->blocked  = !!(src->flags & XEN_DOMINF_blocked);
> +    dst->running  = !!(src->flags & XEN_DOMINF_running);
> +    dst->hvm      = !!(src->flags & XEN_DOMINF_hvm_guest);
> +    dst->debugged = !!(src->flags & XEN_DOMINF_debugged);
...
> -        info->dying    = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_dying);
> -        info->shutdown = 
> !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_shutdown);

This code motion makes the patch a bit harder to review than
necessary.

Would it be possible to split it into a separate patch ("introduce
xc_domaininfo_to_dominfo" I guess), or provide a "git diff -b" ?

I see you are using git.  If you had provided a public git url for
your branch then I would have just looked t6here and asked git for
diff -b ...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel