[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6] interrupts: allow guest to set/clear MSI-X mask bit

>>> On 15.08.13 at 17:47, Joby Poriyath <joby.poriyath@xxxxxxxxxx> wrote:
> @@ -404,7 +436,7 @@ int msixtbl_pt_register(struct domain *d, struct pirq 
> *pirq, uint64_t gtable)
>      entry = new_entry;
>      new_entry = NULL;
> -    add_msixtbl_entry(d, pdev, gtable, entry);
> +    add_msixtbl_entry(d, pdev, gtable, entry, pirq);
>  found:
>      atomic_inc(&entry->refcnt);

Just noticed this "found" label here, which made me go back and
look at the whole function: Did you consider the case of there
already being an entry, and hence add_msixtbl_entry() not
getting called, and thus entry->pirq not getting set to what got
passed in here? I'm assuming that this is only ever the case if
for the entry found entry->pirq == pirq, but if I'm right with
this, adding a respective ASSERT() here would seem desirable.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.