Re: [Xen-devel] [PATCH 3/3] libxc: add xc_tbuf_trace() to insert trace records

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 15/08/13 15:37, George Dunlap wrote:
> On 25/07/13 14:23, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@xxxxxxxxxx>
>>
>> Add xc_tbuf_trace() to allow trace records to be added to the trace
>> buffer.  The subclass and event number and up to 7 uin32_t arguments
>> may be specified.
>>
>> The hypercall sub-op used is HVMOP_xentrace which (despite the name)
>> may be used by PV guests.
> 
> Would it make sense to make this interface more like the hypervisor's
> trace_var() -- that is, taking a sizeof() and single pointer, so that
> callers can easily pass in packed structs?

I did it like this so it would only take a single line to get a useful
trace point.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel