Re: [Xen-devel] [PATCH 3/4] xen/events: initialize local per-cpu mask for all possible events

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.08.13 at 14:21, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -348,7 +348,7 @@ static void init_evtchn_cpu_bindings(void)
>  
>       for_each_possible_cpu(i)
>               memset(per_cpu(cpu_evtchn_mask, i),
> -                    (i == 0) ? ~0 : 0, sizeof(*per_cpu(cpu_evtchn_mask, i)));
> +                    (i == 0) ? ~0 : 0, NR_EVENT_CHANNELS/8);

I think simply dropping the bogus * would have been the better fix.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel