Re: [Xen-devel] [PATCH v3] interrupts: allow guest to set/clear MSI-X mask bit

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.08.13 at 18:36, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 14/08/13 17:30, Andrew Cooper wrote:
>> On 14/08/13 17:18, Joby Poriyath wrote:
>>> @@ -328,7 +345,8 @@ const struct hvm_mmio_handler msixtbl_mmio_handler = {
>>>  static void add_msixtbl_entry(struct domain *d,
>>>                                struct pci_dev *pdev,
>>>                                uint64_t gtable,
>>> -                              struct msixtbl_entry *entry)
>>> +                              struct msixtbl_entry *entry,
>>> +                              struct pirq *pirq)
>> I would advocate const-correctness here, so "const struct pirq *pirq".
> 
> Sorry - please ignore this.  I was being an idiot.

In fact, I don't see why const couldn't be added here. Certainly
pirq_spin_lock_irq_desc() - the only place where it is being
consumed - doesn't need it non-const.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel