Re: [Xen-devel] [PATCH] Add missing return value checks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.08.13 at 22:10, Bastian Blank <bastian@xxxxxxxxxxxx> wrote:
> The return value of vasprintf must be checked. This check is enforced
> with the compiler options used in Debian by request and in Ubuntu by
> default.

The function is not declared with __attribute__((warn_unused_result)),
so what's the deal here? Are you saying that the compiler options are
such that _any_ unused return value would be complained about? I
doubt that, as I'd expect a lot more instances of such throughout the
tree. Hence - what's going on here?

Jan

> Check the return value and abort on error.
> 
> Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>
> 
> diff --git a/tools/tests/mce-test/tools/xen-mceinj.c 
> b/tools/tests/mce-test/tools/xen-mceinj.c
> index e3e62f7..21a488b 100644
> --- a/tools/tests/mce-test/tools/xen-mceinj.c
> +++ b/tools/tests/mce-test/tools/xen-mceinj.c
> @@ -92,7 +92,8 @@ static void Lprintf(const char *fmt, ...)
>      va_list args;
>  
>      va_start(args, fmt);
> -    vasprintf(&buf, fmt, args);
> +    if (vasprintf(&buf, fmt, args) < 0)
> +        abort();
>      fprintf(LOGFILE, "%s", buf);
>      va_end(args);
>      free(buf);
> @@ -104,7 +105,8 @@ static void err(xc_interface *xc_handle, const char *fmt, 
> ...)
>      va_list args;
>  
>      va_start(args, fmt);
> -    vasprintf(&buf, fmt, args);
> +    if (vasprintf(&buf, fmt, args) < 0)
> +        abort();
>      perror(buf);
>      va_end(args);
>      free(buf);
> -- 
> Emotions are alien to me.  I'm a scientist.
>               -- Spock, "This Side of Paradise", stardate 3417.3
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel