[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V10 PATCH 12/23] PVH xen: Support privileged op emulation for PVH

On 09/08/2013 19:10, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>>> That sounds like a good change to me. Jan, you OK with this?
>> It's worse performance wise, but better maintenance wise, so I
>> guess I don't really object (but also am not too happy with it).
> Jan this is confusing. We are looking for you and Keir as guidance
> as both of you are the maintainers and have the final say in the x86
> architecture.
> Which way would you like it?

The way Mukesh already has it is fine. I see no problem with passing in both
the selector value and the enum. Both are readily producible by all callers
it seems. Yes it's a bit redundant but seems not too ugly to me. It's really
a very minor point, and I'd Ack this either way.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.