Re: [Xen-devel] [PATCH v6 3/5] xen: arm: include public/xen.h in foreign interface checking

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-08-08 at 11:57 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH v6 3/5] xen: arm: include 
> public/xen.h in foreign interface checking"):
> > IIRC the magic in mkheader.py requires
> >         #ifdef FOO
> >         struct ...
> >         
> > and cannot cope with 
> > 
> >         #ifdef FOO
> >         #define BAR
> >         struct ...
> >         
> > I could make the regex more complicated to cope with this case but just
> > moving the #define next to its only usage seemed simpler.
> 
> Urgh.  Right.
> 
> > I rewrote the final line of the changelog to be:
> > 
> >    Teach mkheader.py to cope with structs which are ifdef'd. This cannot 
> > cope
> >    with #defines between the #ifdef and the struct definitions, so move
> >    MAX_GUEST_CMDLINE to be next to its only usage.
> > 
> > Does that suffice?
> 
> Yes, thanks.

I'll take this as an Ack unless you object.

Although since it is 15:44 and I'm away on holiday tomorrow and Monday I
shan't actually apply it until next week.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel