Re: [Xen-devel] [PATCH] xen: cleanup unused request{_dt, }_irq() parameter

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.13 at 13:59, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/08/13 08:42, Jan Beulich wrote:
>>>>> On 06.08.13 at 19:42, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>> The irqflags parameter appears to be an unused vestigial parameter right 
> from
>>> the integration of the IOMMU code in 2007.  The parameter is 0 at all
>>> callsites and never used.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Reviewed-by: Jan Beulich <JBeulich@xxxxxxxx>
>>
>> If I were to commit it - with the appropriate acks - I'd also cleanup
>> the white space damage left in place:
>>
>>> --- a/xen/arch/x86/irq.c
>>> +++ b/xen/arch/x86/irq.c
>>> @@ -951,7 +951,7 @@ __initcall(irq_ratelimit_init);
>>>  
>>>  int __init request_irq(unsigned int irq,
>>>          void (*handler)(int, void *, struct cpu_user_regs *),
>>> -        unsigned long irqflags, const char * devname, void *dev_id)
>>> +        const char * devname, void *dev_id)
>> Here ...
>>
>>> --- a/xen/include/xen/irq.h
>>> +++ b/xen/include/xen/irq.h
>>> @@ -93,7 +93,7 @@ extern int setup_irq(unsigned int irq, struct irqaction 
>>> *);
>>>  extern void release_irq(unsigned int irq);
>>>  extern int request_irq(unsigned int irq,
>>>                 void (*handler)(int, void *, struct cpu_user_regs *),
>>> -               unsigned long irqflags, const char * devname, void *dev_id);
>>> +               const char * devname, void *dev_id);
>> ... and here.
>>
>> I'd encourage you to in the future do such obvious cleanup on
>> code you touch anyway.
>>
>> Jan
>>
> 
> Certainly (I tend to, but it slipped my mind this time) - I shall submit v2

No need to do so - as said, if I'm going to be the one to apply this
(likely), I'll do that cleanup as I go.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel