Re: [Xen-devel] [V10 PATCH 21/23] PVH xen: VMX support of PVH guest creation/destruction

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.07.13 at 03:59, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> +static void vmx_update_pvh_cr(struct vcpu *v, unsigned int cr)
> +{
> +    vmx_vmcs_enter(v);
> +    switch ( cr )
> +    {
> +    case 3:
> +        __vmwrite(GUEST_CR3, v->arch.hvm_vcpu.guest_cr[3]);
> +        hvm_asid_flush_vcpu(v);
> +        break;
> +
> +    default:
> +        printk(XENLOG_ERR
> +               "PVH: d%d v%d unexpected cr%d update at rip:%lx\n",
> +               v->domain->domain_id, v->vcpu_id, cr, __vmread(GUEST_RIP));

IMO this should be an ASSERT(), not a printk(), as there should
be no way to get here with an value other then 3 if all code is
working as expected.

Or if this was to remain a printk(), you probably should use 
XENLOG_G_ERR.

Jan

> +    }
> +    vmx_vmcs_exit(v);
> +}



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel