Re: [Xen-devel] [PATCH v3 1/2] xen/arm: Start to implement an ARM decoder instruction

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-07-31 at 17:18 +0100, Julien Grall wrote:


> >> +        switch ( opB & 0x3 )
> >> +        {
> >> +        case 0:
> >> +            dabt->size = 2;
> >> +            break;
> >> +        case 1:
> >> +            dabt->size = 1;
> > 
> > ->sign is uninitialised for these two cases?
> > 
> > Actually, for many of them I think?
> 
> I plan to zeroed the ISS field (ie sign, reg...) by default. See TODO in
> decode_instruction. Do I still need to set sign to 0?

Well, you need to at least do one or the other!

Even if you are zeroing the iss be default I think it would be useful
from a documentation/clarity perspective to set it explicitly to zero.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel