Re: [Xen-devel] [PATCH 5/8] xen/arm: Implement a virtual UART

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-07-29 at 17:40 +0100, Julien Grall wrote:
> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vuart.c
> similarity index 51%
> rename from xen/arch/arm/vpl011.c
> rename to xen/arch/arm/vuart.c
> index 13ba623..5c3a84c 100644
> --- a/xen/arch/arm/vpl011.c
> +++ b/xen/arch/arm/vuart.c
> @@ -1,8 +1,13 @@
>  /*
> - * xen/arch/arm/vpl011.c
> + * xen/arch/arm/vuart.c
>   *
> - * ARM PL011 UART Emulator (DEBUG)
> + * Virtual UART Emulator.
>   *
> + * The emulator uses the information from dtuart. It will expose a basic
     ^This ?

> + * UART which will allow the guest to log with an hardcode UART (early 
> printk +
                                                  a  hardcoded
> + * decompressor).

Please can you combine this with the comment that follows "This is not
intended to be a full emulation" etc so as people are not accidentally
mislead into thinking this is a proper UART emulator. (Also you have a
missed a "PL011" in that other comment)

It might also be worth expanding on what "hardcoded" means, i.e. a
single status register (with a fixed value) and a single byte transmit
register.

The rest looks good, thanks.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel