Re: [Xen-devel] build for pv-grub stubdom

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-07-26 at 15:55 +0200, Samuel Thibault wrote:
> Hello,
> 
> IAN DELANEY, le Mon 22 Jul 2013 00:36:43 +0800, a Ãcrit :
> >  * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
> >    warning: implicit declaration of function
> >    âkillâ [-Wimplicit-function-declaration]
> >    â_fstat64â [-Wimplicit-function-declaration]
> >    â_open64â [-Wimplicit-function-declaration]
> >    âlseek64â [-Wimplicit-function-declaration]
> >    âprofilâ [-Wimplicit-function-declaration]
> 
> We don't actually provide these functions.
> 
> >  * ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
> >    declaration of function âdo_exitâ [-Wimplicit-function-declaration]
> 
> This should be fixed by this I guess:

Ian, can you confirm if these work. If so the Samuel please can I get a
S-o-b (and ideally a commit message so I don't have to fabricate one).

Thanks,
Ian.

> 
> diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
> index 1649d51..15a6583 100644
> --- a/stubdom/grub/config.h
> +++ b/stubdom/grub/config.h
> @@ -2,6 +2,7 @@
>  #undef putchar
>  #include <ctype.h>
>  #include <string.h>
> +#include <kernel.h>
>  #define debug _debug
>  #define grub_halt(a) do_exit()
>  #define printf grub_printf
> 
> >  * 
> > /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
> >    warning: implicit declaration of function
> >    âmemcpyâ [-Wimplicit-function-declaration]
> 
> And that, by that:
> 
> diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
> index 2a6fa54..e65db6d 100644
> --- a/xen/include/xen/libelf.h
> +++ b/xen/include/xen/libelf.h
> @@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
>  #ifdef __XEN__
>  #include <public/elfnote.h>
>  #include <public/features.h>
> +#include <xen/string.h>
>  #else
>  #include <xen/elfnote.h>
>  #include <xen/features.h>
>  
>  #include <stdarg.h>
> +#include <string.h>
>  
>  struct elf_binary;
>  typedef void elf_log_callback(struct elf_binary*, void *caller_data,
> 
> Samuel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel