Re: [Xen-devel] [PATCH 19/24] PVH xen: add hypercall support for PVH

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.07.13 at 04:33, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3188,6 +3188,16 @@ static long hvm_vcpu_op(
>      case VCPUOP_register_vcpu_time_memory_area:
>          rc = do_vcpu_op(cmd, vcpuid, arg);
>          break;
> +
> +    case VCPUOP_is_up:
> +    case VCPUOP_up:
> +    case VCPUOP_initialise:
> +        if ( is_pvh_vcpu(current) )
> +            rc = do_vcpu_op(cmd, vcpuid, arg);
> +        else
> +            rc = -ENOSYS;
> +        break;
> +

As said before, this white listing has to be a temporary thing, and
hence ought to have a fixme note.

> @@ -3349,16 +3379,21 @@ int hvm_do_hypercall(struct cpu_user_regs *regs)
>                      regs->r10, regs->r8, regs->r9);
>  
>          curr->arch.hvm_vcpu.hcall_64bit = 1;
> -        regs->rax = hvm_hypercall64_table[eax](regs->rdi,
> -                                               regs->rsi,
> -                                               regs->rdx,
> -                                               regs->r10,
> -                                               regs->r8,
> -                                               regs->r9); 
> +        if ( is_pvh_vcpu(curr) )
> +            regs->rax = pvh_hypercall64_table[eax](regs->rdi, regs->rsi,
> +                                                   regs->rdx, regs->r10,
> +                                                   regs->r8, regs->r9);
> +        else
> +            regs->rax = hvm_hypercall64_table[eax](regs->rdi, regs->rsi,
> +                                                   regs->rdx, regs->r10,
> +                                                   regs->r8, regs->r9);
>          curr->arch.hvm_vcpu.hcall_64bit = 0;
> +

Adding a stray blank line.

>      }
>      else

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel