Re: [Xen-devel] [PATCH] Add device_model_pvdevice parameter for HVM guests

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-07-18 at 12:16 +0100, Paul Durrant wrote:
> > > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > > index 8a478ba..cfaa54e 100644
> > > > --- a/tools/libxl/xl_cmdimpl.c
> > > > +++ b/tools/libxl/xl_cmdimpl.c
> > > > @@ -1526,6 +1526,20 @@ skip_vfb:
> > > >              exit (1);
> > > >
> > > >          }
> > > > +
> > > > +        if (!xlu_cfg_get_string (config, "device_model_pvdevice", 
> > > > &buf, 0))
> > {
> > > > +            libxl_device_model_pvdevice d;
> > > > +
> > > > +            e = libxl_device_model_pvdevice_from_string(buf, &d);
> > > > +            if (e) {
> > > > +                fprintf(stderr,
> > > > +                        "xl: unknown device_model_pvdevice '%s'\n",
> > > > +                        buf);
> > > > +                exit(-ERROR_FAIL);
> > > > +            }
> > > > +
> > > > +            b_info->u.hvm.device_model_pvdevice = d;
> > 
> > You could do away with d and just pass the real thing to from_string.
> > 
> 
> Yeah, I did this for formatting reasons.
> libxl_device_model_pvdevice_from_string is a very long function name
> already to adding a lengthy argument name on the end just didn't look
> nice.

That's OK. FWIW I'd have done
        e = libxl_device_model_pvdevice_from_string(buf,
                &b_info->xxx);

Up to you though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel