Re: [Xen-devel] [PATCH] xen: x86: drop the ".gz" suffix when installing

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.13 at 13:13, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> As Jan says it is pretty meaningless under /boot anyway. However I am 
> slightly
> concerned about breaking bootloaders (or more specifically their help 
> scripts
> which automatically generate config files). By inspection at leastr grub 2's
> update-grub script (as present in Debian Wheezy) seems to cope (it matches on
> xen* not xen*.gz)

Fine with me (obviously), but ...

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -37,10 +37,10 @@ _build: $(TARGET)$(Z)
>  .PHONY: _install
>  _install: $(TARGET)$(Z)

... where are all those $(Z) coming from? The staging tree doesn't
have this, and I also don't recall having see a respective patch
(and you also don't mention such a patch as prerequisite).

Jan

>       [ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot
> -     $(INSTALL_DATA) $(TARGET)$(Z) $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_FULLVERSION)$(Z)
> -     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> -     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION)$(Z)
> -     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(Z) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))$(Z)
> +     $(INSTALL_DATA) $(TARGET)$(Z) $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_FULLVERSION)
> +     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)
> +     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION)
> +     ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION) 
> $(DESTDIR)/boot/$(notdir 
> $(TARGET))
>       $(INSTALL_DATA) $(TARGET)-syms $(DESTDIR)/boot/$(notdir 
> $(TARGET))-syms-$(XEN_FULLVERSION)
>       if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \
>               [ -d $(DESTDIR)$(EFI_DIR) ] || $(INSTALL_DIR) 
> $(DESTDIR)$(EFI_DIR); \
> @@ -59,10 +59,10 @@ _install: $(TARGET)$(Z)
>  _uninstall: D=$(DESTDIR)
>  _uninstall: T=$(notdir $(TARGET))
>  _uninstall:
> -     rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)
> -     rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> -     rm -f $(D)/boot/$(T)-$(XEN_VERSION)$(Z)
> -     rm -f $(D)/boot/$(T)$(Z)
> +     rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)
> +     rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)
> +     rm -f $(D)/boot/$(T)-$(XEN_VERSION)
> +     rm -f $(D)/boot/$(T)
>       rm -f $(D)/boot/$(T)-syms-$(XEN_FULLVERSION)
>       rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi
>       rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi
> -- 
> 1.7.2.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel