Re: [Xen-devel] pygrub patch to allow explicit offset to fs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-06-24 at 08:17 -0700, Matt Wilson wrote:
> On Thu, Jun 20, 2013 at 01:51:41PM +0200, Kjetil Torgrim Homme wrote:
> > On 19/06/2013 20:10, Matt Wilson wrote:
> > >On Wed, Jun 19, 2013 at 09:44:46AM +0100, Ian Campbell wrote:
> > >>On Wed, 2013-06-19 at 09:39 +0100, Wei Liu wrote:
> > >>>On Wed, Jun 19, 2013 at 09:17:30AM +0100, Ian Campbell wrote:
> > >>>>On Wed, 2013-06-19 at 01:40 +0200, Kjetil Torgrim Homme wrote:
> > >>>>>      # get list of offsets into file which start partitions
> > >>>>>-    part_offs = get_partition_offsets(file)
> > >>>>>+    if user_provided_offset is None:
> > >>>>>+        part_offs = get_partition_offsets(file)
> > >>>>>+    else:
> > >>>>>+        part_offs = [ int(user_provided_offset) ]
> > >>>>Then this can become just:
> > >>>>      if part_offs = None:
> > 
> > thanks for the feedback, everyone.  here's an updated patch.
> > 
> > commit faec4e85318b6769df501d5198b55a607d97c255
> > Author: Kjetil Torgrim Homme <kjetil.homme@xxxxxxxxxxxxxxxxxx>
> > Date:   Thu Jun 20 13:40:21 2013 +0200
> > 
> >     updated patch for pygrub --offset after feedback from mailing list
> > 
> >     Signed-off-by: Kjetil Torgrim Homme <kjetil.homme@xxxxxxxxxxxxxxxxxx>
> 
> Looks good, thanks!
> 
> Reviewed-by: Matt Wilson <msw@xxxxxxxxxx>

I reformatted the commit message and applied, thanks.

pygrub: allow user to specify an explicit offset to fs
    
This new option overrides partition table parsing
    
Signed-off-by: Kjetil Torgrim Homme <kjetil.homme@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Matt Wilson <msw@xxxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel