Re: [Xen-devel] [PATCH] xen/cpuidle: Reduce logging level for unknown apic_ids

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.07.13 at 22:09, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/acpi/cpu_idle.c
> +++ b/xen/arch/x86/acpi/cpu_idle.c
> @@ -1031,7 +1031,7 @@ long set_cx_pminfo(uint32_t cpu, struct 
> xen_processor_power *power)
>      cpu_id = get_cpu_id(cpu);
>      if ( cpu_id == -1 )
>      {
> -        printk(XENLOG_ERR "no cpu_id for acpi_id %d\n", cpu);
> +        printk(XENLOG_INFO "no cpu_id for acpi_id %d\n", cpu);

Could we make this a warning on the first hit, and informational
on subsequent ones, so that at the default log level there's at
least some trace of this in the logs? Or alternatively make this
a warning in all cases, but gate other than the first invocation
on the opt_cpu_info flag (which would then need to be moved
out of __cpuinitdata)?

Also, once at it, could you change the message to something
less tied to C variable names, e.g. "No CPU ID for ACPI ID %#x\n"?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel