Re: [Xen-devel] [PATCH] xen-netfront: pull on receive skb may need to happen earlier

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.07.13 at 22:17, Dion Kant <g.w.kant@xxxxxxxxxx> wrote:
> After some reading I now understand, it is __pskb_pull_tail(skb, pull_to
> - skb_headlen(skb)) which lowers shinfo->nr_frags by one.
> 
> Must we then not first set shinfo->nr_frags to its correct value before
> the call to __pskb_pull_tail(skb, pull_to - skb_headlen(skb)), like below?

Yes, absolutely - your previous mail already made that clear.

Part of the issue here is that I think the code really should be
using skb_add_rx_frag(), which would take care of keeping the
field up-to-date. I'll probably re-write the patch to that effect.

Thanks a lot!

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel