Re: [Xen-devel] [RFC Patch v2 10/16] colo: implement restore_callbacks finish_restore()

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

At 07/11/2013 05:40 PM, Ian Campbell Wrote:
> On Thu, 2013-07-11 at 16:35 +0800, Wen Congyang wrote:
>> [...]
>> diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile
>> index 70994b9..92d11af 100644
>> --- a/tools/libxc/Makefile
>> +++ b/tools/libxc/Makefile
>> @@ -49,7 +49,7 @@ GUEST_SRCS-y += xc_nomigrate.c
>>  endif
>>  
>>  vpath %.c ../../xen/common/libelf
>> -CFLAGS += -I../../xen/common/libelf
>> +CFLAGS += -I../../xen/common/libelf -I../xenstore
> 
> We have avoided needing libxc to speak xenstore so far.

OK. I will fix it in the next version.

> 
> It looks like you only use xs_suspend_evtchn_port, in which case you
> could just pass this from libxc's caller.
> 
>> [...]
> 
>> +    if (colo_data->first_time) {
>> +        sleep(10);
> 
> This can't be right, can it?

Yes, just to wait suspend evtchn port. I will cleanup it in the next version.

Thanks

> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel