[Xen-devel] [PATCH v2 1/2] VT-d: use ioremap()

["Jan Beulich" <JBeulich@xxxxxxxx>]

There's no point in using the fixmap here, and it gets iommu_alloc()
in line with iommu_free(), which was already using iounmap() (thus
crashing if actually used).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>
---
v2: Add error handling to the ioremap() invocation.

--- 2013-06-21.orig/xen/drivers/passthrough/vtd/dmar.h  2013-07-11 
10:05:51.000000000 +0200
+++ 2013-06-21/xen/drivers/passthrough/vtd/dmar.h       2013-07-10 
11:16:27.000000000 +0200
@@ -127,8 +127,6 @@ do {                                    
     }                                                           \
 } while (0)
 
-void *map_to_nocache_virt(int nr_iommus, u64 maddr);
-
 int vtd_hw_check(void);
 void disable_pmr(struct iommu *iommu);
 int is_usb_device(u16 seg, u8 bus, u8 devfn);
--- 2013-06-21.orig/xen/drivers/passthrough/vtd/iommu.c 2013-07-10 
11:29:34.000000000 +0200
+++ 2013-06-21/xen/drivers/passthrough/vtd/iommu.c      2013-07-11 
10:09:36.000000000 +0200
@@ -1142,15 +1142,16 @@ int __init iommu_alloc(struct acpi_drhd_
         return -ENOMEM;
     }
     iommu->intel->drhd = drhd;
+    drhd->iommu = iommu;
 
-    iommu->reg = map_to_nocache_virt(nr_iommus, drhd->address);
+    iommu->reg = ioremap(drhd->address, PAGE_SIZE);
+    if ( !iommu->reg )
+        return -ENOMEM;
     iommu->index = nr_iommus++;
 
     iommu->cap = dmar_readq(iommu->reg, DMAR_CAP_REG);
     iommu->ecap = dmar_readq(iommu->reg, DMAR_ECAP_REG);
 
-    drhd->iommu = iommu;
-
     if ( iommu_verbose )
     {
         dprintk(VTDPREFIX,
--- 2013-06-21.orig/xen/drivers/passthrough/vtd/x86/vtd.c       2013-07-11 
10:05:51.000000000 +0200
+++ 2013-06-21/xen/drivers/passthrough/vtd/x86/vtd.c    2013-07-10 
11:16:14.000000000 +0200
@@ -64,12 +64,6 @@ void flush_all_cache()
     wbinvd();
 }
 
-void *__init map_to_nocache_virt(int nr_iommus, u64 maddr)
-{
-    set_fixmap_nocache(FIX_IOMMU_REGS_BASE_0 + nr_iommus, maddr);
-    return (void *)fix_to_virt(FIX_IOMMU_REGS_BASE_0 + nr_iommus);
-}
-
 static int _hvm_dpci_isairq_eoi(struct domain *d,
                                 struct hvm_pirq_dpci *pirq_dpci, void *arg)
 {
--- 2013-06-21.orig/xen/include/asm-x86/fixmap.h        2013-07-11 
10:05:51.000000000 +0200
+++ 2013-06-21/xen/include/asm-x86/fixmap.h     2013-07-10 11:16:00.000000000 
+0200
@@ -60,8 +60,6 @@ enum fixed_addresses {
     FIX_KEXEC_BASE_0,
     FIX_KEXEC_BASE_END = FIX_KEXEC_BASE_0 \
       + ((KEXEC_XEN_NO_PAGES >> 1) * KEXEC_IMAGE_NR) - 1,
-    FIX_IOMMU_REGS_BASE_0,
-    FIX_IOMMU_REGS_END = FIX_IOMMU_REGS_BASE_0 + MAX_IOMMUS-1,
     FIX_IOMMU_MMIO_BASE_0,
     FIX_IOMMU_MMIO_END = FIX_IOMMU_MMIO_BASE_0 + IOMMU_PAGES -1,
     FIX_TBOOT_SHARED_BASE,

Attachment: VT-d-use-ioremap.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel