Re: [Xen-devel] [RFC PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.07.13 at 21:13, Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -196,14 +196,21 @@ static void __init ati_bugs_contd(int num, int slot, 
> int func)
>  static void __init intel_remapping_check(int num, int slot, int func)
>  {
>       u8 revision;
> +     u16 device;
>  
> +     device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID);
>       revision = read_pci_config_byte(num, slot, func, PCI_REVISION_ID);
>  
>       /*
>        * Revision 0x13 of this chipset supports irq remapping
>        * but has an erratum that breaks its behavior, flag it as such
>        */
> -     if (revision == 0x13)
> +     if ((device == 3405) &&

0x3405.

Also, I'd do the revision == 0x13 check first (uniformly for all
matched IDs), but I admit that this is a matter of taste. So
consider this

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

with the above mistake fixed.

Jan

> +         ((revision == 0x12) ||
> +          (revision == 0x13) ||
> +          (revision == 0x22))) {
> +             set_irq_remapping_broken();
> +     } else if (revision == 0x13)
>               set_irq_remapping_broken();
>  
>  }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel