Re: [Xen-devel] Ping: [PATCH] bitmap_*() should cope with zero size bitmaps

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.07.13 at 09:53, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 02/07/2013 07:54, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>>>>> On 03.06.13 at 15:33, Jan Beulich wrote:
>>> ... to match expectations set by memset()/memcpy().
>>> 
>>> Similarly for find_{first,next}_{,zero_}_bit() on x86.
>>> 
>>> __bitmap_shift_{left,right}() would also need fixing (they more
>>> generally can't cope with the shift count being larger than the bitmap
>>> size, and they perform undefined operations by possibly shifting an
>>> unsigned long value by BITS_PER_LONG bits), but since these functions
>>> aren't really used anywhere I wonder if we wouldn't better simply get
>>> rid of them.
> 
> Do we have any zero-sized bitmaps? I'm not sure if this is a bug fix, or
> just some paranoia? Anyway, the actual patch looks good.

At least we did prior to commit 5cffb77c ("x86/MCE: disable if MCE
banks are not present").

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel