Re: [Xen-devel] [PATCH] qemu-xen-trad: free all the pirqs for msi/msix when driver unload

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 1 Jul 2013, George Dunlap wrote:
> On Mon, Jul 1, 2013 at 4:34 AM, Zhenzhong Duan
> <zhenzhong.duan@xxxxxxxxxx> wrote:
> > Pirqs are not freed when driver unloads, then new pirqs are allocated when
> > driver reloads. This could exhaust pirqs if do it in a loop.
> >
> > This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in
> > msi/msix control reg.
> >
> > There is also other way of fixing it such as reuse pirqs between driver 
> > reload,
> > but this way is better.
> > Xen-devel: http://marc.info/?l=xen-devel&m=136800120304275&w=2
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> 
> Thanks Zhenzhong.
> 
> >From what I understand following the conversation, I think this is
> probably the right way to solve the problem, but given that it's only
> really a problem when you load and unload drivers, which is the
> uncommon case, I think at this point we should probably hold off on
> this one until 4.3.1.
> 
> Stefano, thoughts?

I think that's OK. I'll wait to apply the qemu-xen patch until after the
release.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel