Re: [Xen-devel] [PATCH] xen/arm: gic_shutdown_irq must only disable the right IRQ

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-06-28 at 12:32 +0100, Stefano Stabellini wrote:
> On Fri, 28 Jun 2013, Julien Grall wrote:
> > When GICD_ICENABLERn is read, all the 1s bit represent enabled IRQs.
> > Currently gic_shutdown_irq:
> >     - read GICD_ICENABLER
> >     - set the corresping bit to 1
> >     - write back the new value
> > That means, Xen will disable more IRQs than necessary.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> It's impressive for how long we got this bug.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

I think you meant Acked-by, so applied with both our acks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel