Re: [Xen-devel] [PATCH] pygrub/GrubConf: fix boot problem for fedora 19 grub.cfg (2nd attempt)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-06-26 at 17:05 +0100, George Dunlap wrote:
> On Wed, Jun 26, 2013 at 4:01 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
> > On Mon, Jun 24, 2013 at 06:21:32PM +0200, Marcel J.E. Mol wrote:
> >> Booting a fedora 19 domU failed because a it could not properly
> >> parse the grub.cfg file. This was cased by
> >>
> >>       set default="${next_entry}"
> >>
> >> This statement actually is within an 'if' statement, so maybe it would
> >> be better to skip code within if/fi blocks...
> >> But this patch seems to work fine.
> >>
> >> Signed-off-by: Marcel Mol <marcel@xxxxxxx>
> >
> > Excellent, and also
> >
> > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> >
> > and it also fixes Red Hat bug: 978036
> >
> > George, would you be OK putting this in 4.3?
> 
> Hrm.  On further review, since this affects basically all Fedora
> installations, and it mirrors a grub changeset that directlys witches
> ${saved_entry} to ${next_entry}, I guess on the whole it's worth the
> risk.
> 
> Re the release:
> 
> Not-very-happilly-Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Applied.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel