[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/4] time: add a notifier chain for when the system time is stepped
On 06/24/2013 10:00 AM, David Vrabel wrote: On 24/06/13 17:30, Thomas Gleixner wrote:@@ -508,7 +509,7 @@ int do_settimeofday(const struct timespec *tv)tk_set_xtime(tk, tv); - timekeeping_update(tk, true, true);+ timekeeping_update(tk, true, true, true);These three booleans in a row is getting a bit opaque. How about I also change it to a set of flags? e.g., timekeeping_updated(tk, TK_CLEAR_NTP | TK_MIRROR | TK_CLOCK_WAS_SET); Yea. I'm not a fan of the bool arguments to functions (which I have to look up every time as which bool is which). The bitflag approach is nicer in my mind, since its a bit more explicit when reading the code. The other approach would be to have different function calls (timekeeping_clear_ntp, timekeeping_mirror, timekeeping_clock_was_set), which call into the same back end logic. thanks -john _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |