Re: [Xen-devel] [PATCH 4/4] xen/arm: enable switch to hyper mode for sun6i

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-06-18 at 04:39 -0600, Bamvor Jian Zhang wrote:
> Ian Campbell wrote:
> > On Tue, 2013-06-18 at 00:38 -0600, Bamvor Jian Zhang wrote:
> > > > I don't know which one applies to the sun6i platform -- it looks to me
> > > > like upstream u-boot support is well under way and the presence of FEL
> > > > mode makes unbricking the system pretty easy (I've had to use it on my
> > > > own A31 based tablet and it seems OK).
> > 
> > > i will investigate it. do i have change to got other part of my patch ack
> > > without this bootwrapper or u-boot support? 
> > 
> > Not sure what you are asking but if it is "can patches #1-#3 be accepted
> > without this change" then the answer is yes IMHO.
> yes, this is what i mean. sorry for the typo.
> > 
> > In the meantime while we work on bootwrapper/u-boot support generally we
> > should also patch this code to not fallback to the vexpress for
> > everything, if the platform isn't explicitly either Arndale or vexpress
> > it should do nothing.
> So, i could check the vexpress machine id in enter_hyp_mode when it is not
> Arndale. then raise error and hang if both check fails.

It should return without doing anything rather than raising an error,
but otherwise yes.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel