Re: [Xen-devel] [PATCH] xentrace: Correct PV trace dump

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 13/06/13 15:27, Egger, Christoph wrote:
> On 13.06.13 16:17, George Dunlap wrote:
> > On 13/06/13 11:51, Egger, Christoph wrote:
> > > On 13.06.13 12:39, Andrew Cooper wrote:
> > > > On 13/06/13 11:22, Christoph Egger wrote:
> > > > > commit c1855d1ad8c5ce218b5ef6825401dc985a3d1f4d
> > > > > Author: Christoph Egger <chegger@xxxxxxxxx>
> > > > > Date:   Fri May 24 11:33:38 2013 +0000
> > > > >
> > > > >       xentrace: Correct PV trace dump
> > > > >            Signed-off-by: Christoph Egger <chegger@xxxxxxxxx>
> > > > Can you describe in the commit message what you are changing and why?
> > > Without this patch the PV traces are not decoded at all
> > > as the identifier is wrong.
> > >
> > > This patch makes the identifier match with
> > > xen/include/public/trace.h and the PV traces get decoded correctly.
> > I think he was asking you to re-send the patch with a more descriptive
> > commit message.
> Done.
No, not really.

What you wrote above is starting to become a descriptive message -- what 
you put in the re-sent patch is basically nothing.  You need to write 
what the problem was, and and also the technical thing that you are doing.
In particular, in this case, a whole series of trace records in 
xentrace_format have "1" for the subclass field, when they should have "f".
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel