Re: [Xen-devel] [PATCH] x86: drop setup_idle_pagetable()

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 12/06/2013 16:14, "George Dunlap" <george.dunlap@xxxxxxxxxxxxx> wrote:

> On 12/06/13 15:59, Jan Beulich wrote:
>> With vcpu->domain->arch.perdomain_l3_pg no longer getting set up for
>> the idle domain, this creates an invalid L4 entry (due to translating
>> a NULL struct page_info pointer to a physical address).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I don't think it buys very much awesomeness, but it should certainly be
> pretty low risk.
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Pagetable entries pointing into the wilderness are actively dangerous. At
the very least they can cause cache-attribute collisions. This is a real bug
fix.

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel