Re: [Xen-devel] xl save but leave domain paused

[Ian Murray <murrayie@xxxxxxxxxxx>]

> 
> It seems like useful functionality to me, so subject to reviewing the
> actual implementation I think it more than likely would.
> 


I see there is a longterm goal for snapshoting....

"

Full-VM snapshotting owner: ? status: none prognosis: Probably delay until 4.4 
Have a way of coordinating the taking and restoring of VM memory and disk 
snapshots.  This would involve some investigation into the best way to 
accomplish this."

I don't know if my proposed solution meets that requirement. I would argue that 
snapshotting of the virtual disk is beyond the scope of the hypervisor tools 
because there are many different ways to implement a virtual disk, each with 
their own "snapshotting" methods....

So perhaps it does meet the requirement.


>> 
>>  The code I ended up with was (which is what I think you expected):-
> 
> Yep, minus the fprintf which I don't think is needed.
> 

Yeah, that was in to make sure I was defintely running the right code, as pause 
straight after the suspend has the same output

>> 
>>      if (leavepaused || checkpoint || rc < 0) {
>>          if (leavepaused && ! (rc < 0)) {
> 
> I think the libxl coding style would be to cuddle the ! against the
> bracket.
> 

Lol, I will take a look at the rest of the code to make sure it is in the same 
style.

>>              libxl_domain_pause(ctx, domid);
>>              fprintf(stderr, "Pausing before resume\n");
>>          }
>>          libxl_domain_resume(ctx, domid, 1, 0);
>>      }
>>      else
>>           libxl_domain_destroy(ctx, domid, 0);
>> 
>> 
>>  > 
>>  > Ian.
>>  > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel