Re: [Xen-devel] [PATCH 02/18] PVH xen: add XENMEM_add_to_physmap_range

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Fri, 31 May 2013 10:28:54 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 25.05.13 at 03:25, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> 
> > +        if ( xsm_add_to_physmap(XSM_TARGET, current->domain, d) )
> > +        {
> > +            rcu_unlock_domain(d);
> > +            return -EPERM;
> > +        }
> I realize there's another such bogus use of the function in the same
> file, but you shouldn't propagate that mistake: The function has a
> proper return value, and that's what should be used here instead
> of forcing it to be -EPERM.

Ok, changed. 

> 
> I also vaguely recall having pointed out in a much earlier review
> that this functionality is lacking a counterpart in
> compat_arch_memory_op().

Hmm.. confused how/why a 64bit PVH go thru compat_arch_memory_op()? Can
you pl explain?

thanks,
M-



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel