[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Xen-users] kernel 3.9.2 - xen 4.2.2/4.3rc1 => BUG unable to handle kernel paging request netif_poll+0x49c/0xe8
>>> On 31.05.13 at 17:47, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> --- a/drivers/xen/netfront/netfront.c
> +++ b/drivers/xen/netfront/netfront.c
> @@ -1319,6 +1319,7 @@ static RING_IDX xennet_fill_frags(struct netfront_info
> *np,
> kfree_skb(nskb);
>
> nr_frags++;
> + BUG_ON(nr_frags >= MAX_SKB_FRAGS);
Isn't this going to see false positives? I would have thought such a
check would need to go at the top of the loop body.
Jan
> }
>
> shinfo->nr_frags = nr_frags;
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
