Re: [Xen-devel] [PATCH v2] tools/xen-mceinj: support AMD

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.05.13 at 16:13, Christoph Egger <chegger@xxxxxxxxx> wrote:
> On 31.05.13 13:31, Liu, Jinsong wrote:
>>> +/* AMD: Memory Error */
>>> +#define MCG_STATUS_MEM_VAL        0x5
>>> +#define MCE_MEM_BANK              0x4
>>> +#define MCi_STATUS_MEM_VAL        0xb4000000001c0100UL
>>> +//#define MCi_STATUS_MEM_VAL        0xb600000000000100UL
>> 
>> Hmm, drop this test code please.
> 
> What do you not like? The // ?

Here I agree with Jinsong - without comment explaining what the
commented out line could be used for, it should be removed.

And if it is to be kept, it should - together with the explanation -
go into a proper C-style comment.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel