Re: [Xen-devel] Xen 4.3 development update -- RC3 willo be an actual candidate, please test

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 31/05/13 07:13, Jan Beulich wrote:
>>>> On 30.05.13 at 19:33, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> FWIW,
>>
>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2ae8b9173fb2388af651 
>> 4c730d620ed5f450bc34
>>
>> was also debugging and should probably come back out.  I am not certain
>> that it actually caught any issues, but we did the fixing up of legacy
>> PIC interrupts which I suspect might have been the cause of this.
> Indeed, though I would just frame the block by #ifndef NDEBUG.
> Keir - do you have any preference here?
>
> Jan
>

Having used similar debugging structures for this recent XSA-36 related
issue, the result from this change is not actually too useful.

I would certainly suggest complete removal over having in in an NDEBUG
section.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel