Re: [Xen-devel] [PATCH v2] tools/xen-mceinj: support AMD

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.05.13 at 16:33, "Egger, Christoph" <chegger@xxxxxxxxx> wrote:
> a8206654c64f:patches chegger$ cat xen_mceinj.diff
> commit a277555e158c87aed34196f72eba0a4cf8f0fb38
> Author: Christoph Egger <chegger@xxxxxxxxx>
> Date:   Wed Feb 27 14:52:19 2013 +0000
> 
>     xen-mceinj: Support AMD. Add -e option.
> 
>     Add support for AMD.
>     Add -e option to raise an exception.
> 
>     Signed-off-by: Christoph Egger <chegger@xxxxxxxxx>

Apart from needing an ack from someone at Intel, this also is in
need of quite a bit of coding style cleanup - the utility so far is,
with a few exceptions, written in hypervisor style, so your
additions should follow suit.

> @@ -145,7 +179,7 @@ static int mca_cpuinfo(xc_interface *xc_handle)
>          return 0;
>  }
> 
> -static int inject_cmci(xc_interface *xc_handle, int cpu_nr)
> +static int intel_inject_cmci(xc_interface *xc_handle)
>  {
>      struct xen_mc mc;
>      int nr_cpus;

I didn't look too closely, but at least this one is still an unrelated
change that's also not mentioned in the description (i.e. as being
cleanup that's being done as you go).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel