Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes

[John Stultz <john.stultz@xxxxxxxxxx>]

On 05/29/2013 02:37 AM, David Vrabel wrote:
> On 29/05/13 08:47, Jan Beulich wrote:
> > > > > On 28.05.13 at 20:22, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> > > @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now)
> > >   
> > >   static int xen_set_wallclock(const struct timespec *now)
> > >   {
> > > -       struct xen_platform_op op;
> > > -       int ret;
> > > -
> > >         /* do nothing for domU */
> > >         if (!xen_initial_domain())
> > >                 return -1;
> > >   
> > > -	/* Set the Xen wallclock. */
> > > +       /* Set the hardware RTC. */
> > > +       return mach_set_rtc_mmss(now);
> > > +
> > > +}
> > Can't you achieve the same effect in a cleaner way by overriding
> > x86_platform.set_wallclock only in the non-init-domain case?
> Yes, that makes sense.  John, don't apply this one yet, thanks.
Ok. Zapped from my tree.

thanks
-john


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel