Re: [Xen-devel] [BUG, PATCH] xen-4.1-3 xend/XendDomainInfo.py#device_configure() TypeError

[Philipp Hahn <hahn@xxxxxxxxxxxxx>]

Hello,

Am Dienstag 28 Mai 2013, 17:25:52 schrieben Sie:
> >     def _getDeviceInfo_vbd(self, devid):
> >         for dev_type, dev_info in self.info.all_devices_sxpr()
...
> >                 return dev_info
> 
> Ewwww, that looks buggy. Could you just do 'return dev' ?

I don't think that this would be correct, since dev and devid are just the 
device numbers, but dev_info contains the device details  as an Sxpr:
devid='768'
dev='hda:cdrom' ... dev='hda' ... dev=768
dev_type='vbd'
dev_info=['vbd', ('uuid', '920a5c24-28c6-6abb-ad47-9c1144012986'), ('bootable', 
1), ('driver', 'paravirtualised'), ('dev', 'hda:cdrom'), ('uname', 
'file:/var/lib/libvirt/images/UCS_3.1-1-amd64.iso'), ('mode', 'r'), ('VDI', 
''), ('backend', 0)]

So chaning the return type of the function with the name _get*DeviceInfo* look 
wrong. Or am I missing something?

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      hahn@xxxxxxxxxxxxx
Univention GmbH        be open.                       fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel