Re: [Xen-devel] [PATCH 2] xmem/tmem: fix 'undefined variable' build error.

[Frederico Cadete <frederico@xxxxxxxxx>]

On Tue, May 28, 2013 at 09:53:21AM -0400, Konrad Rzeszutek Wilk wrote:
> You are missing an Signed-off-by here. Are you OK affixing it here?
> 
Sorry, my bad. And checkpatch warned me about that...

A fixed version of the patch follows below. Thanks for being so patient.

Regards,
Frederico


From: Frederico Cadete <frederico@xxxxxxxxx>
Date: Tue, 28 May 2013 16:19:49 +0200
Subject: [PATCH 2] xmem/tmem: fix 'undefined variable' build error.

In the (not so useful) kernel configuration where CONFIG_SWAP
is undefined and CONFIG_XEN_SELFBALLOONING is defined,
xen_tmem_init would use undefined variable 'static bool frontswap'.

Added #else to have #define frontswap (0) in the case where
CONFIG_FRONTSWAP is not defined.

Signed-off-by: Frederico Cadete <frederico@xxxxxxxxx>
---
 drivers/xen/tmem.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c
index 18e8bd8..cc072c6 100644
--- a/drivers/xen/tmem.c
+++ b/drivers/xen/tmem.c
@@ -41,6 +41,8 @@ module_param(selfballooning, bool, S_IRUGO);
 #ifdef CONFIG_FRONTSWAP
 static bool frontswap __read_mostly = true;
 module_param(frontswap, bool, S_IRUGO);
+#else /* CONFIG_FRONTSWAP */
+#define frontswap (0)
 #endif /* CONFIG_FRONTSWAP */
 
 #ifdef CONFIG_XEN_SELFBALLOONING
-- 
1.7.9.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel