Re: [Xen-devel] [PATCH] drivers/exynos4210: Wait the end of last transfer before initializing the UART

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/23/2013 01:01 PM, Ian Campbell wrote:

> On Thu, 2013-05-23 at 12:58 +0100, Ian Campbell wrote:
>> On Wed, 2013-05-22 at 12:50 +0100, Julien Grall wrote:
>>> When early printk is enabled by the user, it's possible to loose the last
>>> characters if the UART is initialized without waiting that the last transfer
>>> was completed.
>>
>> It might actually be useful to do this in early_printk, i.e. a new
>> early_uart_flush or so called from puts and early_puts (or even just
>> from the putch hook).
> 
> BTW, my concern here is crashing without flushing the buffer and
> therefore missing a useful message or having a misleading log...
> 
> 


Right. The change is not complicate, so I will create early_uart_flush
and call it in early_printk.

-- 
Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel