Re: [Xen-devel] [Patch[ xl problems with xendomains

[Ian Murray <murrayie@xxxxxxxxxxx>]

----- Original Message -----
> From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> To: Ian Murray <murrayie@xxxxxxxxxxx>
> Cc: ian.jackson@xxxxxxxxxxxxx; xen-devel <xen-devel@xxxxxxxxxxxxx>
> Sent: Wednesday, 22 May 2013, 10:53
> Subject: Re: [Xen-devel] [Patch[ xl problems with xendomains
> 


> 
> $HEADER presumably includes spaces, because the xl save header does, and
> therefore requires quoting. This was also broken for xm because even
> though the xm save header has no spaces the point of this check is to
> look for corrupt/invalid save files, which may well have a space.
> 

Yeah, by that point $HEADER should have "Xen saved domain" which indeed does 
include spaces. Makes perfect sense.


> 
> It looks correct to me.
> 

Great. :)


> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> That actual patch seems to be a bit mangled (looks like an unresolved
> git conflict 3 way diff thing). Since it is simple I can fix it up as I
> apply.
> 

I just diffed the original file with a changed version. Anyway, as you say, 
whatever the issue, it's pretty obvious what is going on.

Thanks for actioning it and look forward to see it in Xen, whenever that is.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel