Re: [Xen-devel] [PATCH net-next] xen-netfront: avoid leaking resources when setup_netfront fails

[David Miller <davem@xxxxxxxxxxxxx>]

From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Fri, 17 May 2013 10:43:58 +0100

>  
> + /* If we fail to setup netfront, it is safe to just revoke access to granted
> +  * pages because backend is not accessing it at this point.
> +  */
> + bind_fail:
> +     xenbus_free_evtchn(dev, info->evtchn);
> + alloc_evtchn_fail:
> +     gnttab_end_foreign_access_ref(info->rx_ring_ref, 0);
> + grant_rx_ring_fail:
> +     free_page((unsigned long)rxs);
> + alloc_rx_ring_fail:
> +     gnttab_end_foreign_access_ref(info->tx_ring_ref, 0);
> + grant_tx_ring_fail:
> +     free_page((unsigned long)txs);
>   fail:
>       return err;
>  }

This is not even close to adhering to proper coding style.

The comment should be indented by one tab not one space:

        /* Like
         * this.
         */

And the code labels should appear at the first column, not
with a leading space.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel