Re: [Xen-devel] [PATCH] xen-blk(front|back): Handle large physical sector disks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.13 at 12:58, Stefan Bader <stefan.bader@xxxxxxxxxxxxx> wrote:
> @@ -1437,6 +1441,17 @@ static void blkfront_connect(struct blkfront_info 
> *info)
>               return;
>       }
> 
> +     /*
> +      * physcial-sector-size is a newer field, so old backends may not
> +      * provide this. Assume physical sector size to be the same as
> +      * sector_size in that case.
> +      */
> +     err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> +                         "physical-sector-size", "%u", &physical_sector_size,
> +                         NULL);

Sorry I didn't pay attention to this in the first round: xenbus_scanf()
should be preferred (for it having better type checking) over
xenbus_gather() for single item operations.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel